From: Florian Müllner <fmuellner@gnome.org>
Date: Sat, 21 Dec 2019 03:00:56 +0000 (+0100)
Subject: st/password-entry: Fix memory leak
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~781^2^2~283
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=c2609227ff02b7281c5caf4ea698187807b28b2f;p=gnome-shell.git

st/password-entry: Fix memory leak

The peek-password icon is currently created twice, whoops.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/910
---

diff --git a/src/st/st-password-entry.c b/src/st/st-password-entry.c
index bbca7a261..31c1ae68c 100644
--- a/src/st/st-password-entry.c
+++ b/src/st/st-password-entry.c
@@ -164,12 +164,6 @@ st_password_entry_init (StPasswordEntry *entry)
                                            NULL);
   st_entry_set_secondary_icon (ST_ENTRY (entry), priv->peek_password_icon);
 
-  priv->peek_password_icon = g_object_new (ST_TYPE_ICON,
-                                           "style-class", "peek-password",
-                                           "icon-name", "eye-not-looking-symbolic",
-                                           NULL);
-  st_entry_set_secondary_icon (ST_ENTRY (entry), priv->peek_password_icon);
-
   clutter_text = st_entry_get_clutter_text (ST_ENTRY (entry));
   clutter_text_set_password_char (CLUTTER_TEXT (clutter_text), BLACK_CIRCLE);